Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter usage for partial reading #11835

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 09:59:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 07ee231 has started.
2024-11-21 09:59:51 UTC Artifacts will be uploaded here
2024-11-21 10:03:20 UTC ya make is running...
2024-11-21 10:23:23 UTC Check cancelled

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 09:59:47 UTC Pre-commit check linux-x86_64-release-asan for 07ee231 has started.
2024-11-21 09:59:58 UTC Artifacts will be uploaded here
2024-11-21 10:03:13 UTC ya make is running...
2024-11-21 10:23:22 UTC Check cancelled

@iddqdex
Copy link
Collaborator

iddqdex commented Nov 21, 2024

#11766

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 10:25:39 UTC Pre-commit check linux-x86_64-release-asan for 1b062fc has started.
2024-11-21 10:25:58 UTC Artifacts will be uploaded here
2024-11-21 10:29:18 UTC ya make is running...
2024-11-21 10:53:26 UTC Check cancelled

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 10:25:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b062fc has started.
2024-11-21 10:25:58 UTC Artifacts will be uploaded here
2024-11-21 10:29:22 UTC ya make is running...
2024-11-21 10:53:29 UTC Check cancelled

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 10:57:38 UTC Pre-commit check linux-x86_64-release-asan for 9931718 has started.
2024-11-21 10:58:11 UTC Artifacts will be uploaded here
2024-11-21 11:01:49 UTC ya make is running...
🟡 2024-11-21 12:35:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10508 10440 0 10 9 49

🟢 2024-11-21 12:36:26 UTC Build successful.
🟢 2024-11-21 12:36:53 UTC ydbd size 4.9 GiB changed* by +6.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45513a5 merge: 9931718 diff diff %
ydbd size 5 281 485 464 Bytes 5 281 491 720 Bytes +6.1 KiB +0.000%
ydbd stripped size 1 359 039 984 Bytes 1 359 040 528 Bytes +544 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 10:58:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9931718 has started.
2024-11-21 10:58:53 UTC Artifacts will be uploaded here
2024-11-21 11:02:22 UTC ya make is running...
🟡 2024-11-21 12:37:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41944 36266 0 2 5558 118

2024-11-21 12:41:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-21 12:53:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 4 0 0 1 108

🟢 2024-11-21 12:53:37 UTC Build successful.
🟢 2024-11-21 12:53:56 UTC ydbd size 2.5 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45513a5 merge: 9931718 diff diff %
ydbd size 2 690 194 576 Bytes 2 690 198 088 Bytes +3.4 KiB +0.000%
ydbd stripped size 482 358 064 Bytes 482 358 256 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 21, 2024 14:13
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 21, 2024 14:13
@ivanmorozov333 ivanmorozov333 merged commit 25f884a into ydb-platform:main Nov 21, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_filter_usage_control branch November 21, 2024 14:15
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants