Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner and more specific way to implement comment section for posts #39

Open
wants to merge 2 commits into
base: feature/disqus
Choose a base branch
from

Conversation

Hussain-Alsalman
Copy link

Hello Yihui,

This is my implementation of the comment section that is only specific to posts I mentioned a while ago. It can also be enabled and disabled from config.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The two CSS files under public/ do not seem to be necessary for this PR.

@Hussain-Alsalman
Copy link
Author

You are right. I haven't notice how it lingered into my commit. All is fixed now

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2020

CLA assistant check
All committers have signed the CLA.

@yihui yihui force-pushed the feature/disqus branch 2 times, most recently from b6578bf to 2b4c7dc Compare October 11, 2020 20:52
@SiddharthShyniben
Copy link

Link: https://deploy-preview-39--hugo-xmin.netlify.app/

Just in case anyone wants to preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants