Update view generators/crud/default/controller
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix return type in PhpDoc Add Php 7 features (optional) Use `Yii::createObject()` instead `new className()`
samdark
requested changes
Sep 27, 2021
| @@ -184,10 +190,11 @@ protected function findModel(<?= $actionParams ?>) | |||
| } | |||
| $condition = '[' . implode(', ', $condition) . ']'; | |||
| ?> | |||
| if (($model = <?= $modelClass ?>::findOne(<?= $condition ?>)) !== null) { | |||
There was a problem hiding this comment.
It was OK as is. No need for change here.
There was a problem hiding this comment.
@samdark it's less readable
There was a problem hiding this comment.
No, it's not. That's more of personal preferences. I'd not change it for that reason.
There was a problem hiding this comment.
There was a problem hiding this comment.
Other than that, you've changed early return to late return complicating the code a bit. With this assign in condition I agree.
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
reviewed
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix return type in PhpDoc
Add Php 7 features (optional)