Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Generator.php #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Generator.php #545

wants to merge 1 commit into from

Conversation

spzgy
Copy link

@spzgy spzgy commented Nov 22, 2023

In yii\db\BaseActiveRecord, there is no getTableSchema method. When using Gii to generate CRUD for non-relational databases, an error occurs because the getTableSchema method cannot be found.

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

In yii\db\BaseActiveRecord, there is no getTableSchema method. When using Gii to generate CRUD for non-relational databases, an error occurs because the getTableSchema method cannot be found.
Copy link

what-the-diff bot commented Nov 22, 2023

PR Summary

  • Updated ActiveRecord Class in Generator
    The type of ActiveRecord we use in our 'Generator' code file has been updated. Instead of 'BaseActiveRecord', now 'ActiveRecord' is used which means we're accessing the more comprehensive functionality provided by ActiveRecord. This could potentially increase efficiency and manageability of the code.

@samdark
Copy link
Member

samdark commented Nov 23, 2023

Please add a line for CHANGELOG. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants