remove useless function definitions #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, these definitions are placed for the IDE type-hinting. |
|
@klimov-paul I thought it was for type-hinting and made it more clean |
|
@klimov-paul do you want to say that my + *
+ * @method <?= $modelFullClassName ?>[]|array all($db = null)
+ * @method <?= $modelFullClassName ?>|array|null one($db = null)would not work as IDE type-hinting? phpstorm work well. |
|
These should work. @dizews could you check NetBeans? |
|
@samdark it work in the NetBeans. |
|
@cebe is it a problem for our doc generator? |
|
it does not consider |
|
OK. Then this pull request should wait till it's supported. |
|
@cebe is there any change in regards to doc tool? |
|
created an issue yiisoft/yii2-apidoc#136 |
arogachev
reviewed
Dec 6, 2021
| @@ -31,21 +34,4 @@ class <?= $className ?> extends <?= '\\' . ltrim($generator->queryBaseClass, '\\ | |||
| return $this; | |||
| }*/ | |||
|
|
|||
There was a problem hiding this comment.
(Code style) Remove newline.
|
This can be merged now. |
machour
approved these changes
Dec 6, 2021
|
@arogachev there are conflicts to be resolved first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it look like more clean then before