Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless function definitions #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dizews
Copy link
Contributor

@dizews dizews commented Sep 28, 2015

I think it look like more clean then before

@klimov-paul
Copy link
Member

No, these definitions are placed for the IDE type-hinting.

@dizews
Copy link
Contributor Author

dizews commented Sep 28, 2015

@klimov-paul I thought it was for type-hinting and made it more clean

@dizews
Copy link
Contributor Author

dizews commented Sep 29, 2015

@klimov-paul do you want to say that my

+ *
+ * @method <?= $modelFullClassName ?>[]|array all($db = null)
+ * @method <?= $modelFullClassName ?>|array|null one($db = null)

would not work as IDE type-hinting? phpstorm work well.

@samdark
Copy link
Member

samdark commented Sep 29, 2015

These should work. @dizews could you check NetBeans?

@dizews
Copy link
Contributor Author

dizews commented Oct 1, 2015

@samdark it work in the NetBeans.

@samdark
Copy link
Member

samdark commented Oct 1, 2015

@cebe is it a problem for our doc generator?

@cebe
Copy link
Member

cebe commented Oct 3, 2015

it does not consider @method annotations yet so application docs will show docs for original implementation.

@samdark
Copy link
Member

samdark commented Oct 3, 2015

OK. Then this pull request should wait till it's supported.

@samdark
Copy link
Member

samdark commented Jan 30, 2017

@cebe is there any change in regards to doc tool?

@cebe
Copy link
Member

cebe commented Jan 30, 2017

created an issue yiisoft/yii2-apidoc#136

@@ -31,21 +34,4 @@ class <?= $className ?> extends <?= '\\' . ltrim($generator->queryBaseClass, '\\
return $this;
}*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Code style) Remove newline.

@arogachev arogachev requested a review from a team December 6, 2021 10:47
@arogachev arogachev self-assigned this Dec 6, 2021
@arogachev
Copy link
Contributor

This can be merged now.

@samdark
Copy link
Member

samdark commented Dec 8, 2021

@arogachev there are conflicts to be resolved first.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants