Fix file uploader, test typed attributes #20167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20167 +/- ##
============================================
- Coverage 22.16% 13.51% -8.66%
+ Complexity 11386 11380 -6
============================================
Files 430 430
Lines 37113 37082 -31
============================================
- Hits 8225 5010 -3215
- Misses 28888 32072 +3184 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
May 27, 2024
samdark
approved these changes
May 28, 2024
|
Would you please add a line for CHANGELOG? |
Arhell
approved these changes
May 29, 2024
|
👍 |
marcovtwout
reviewed
Jul 22, 2024
| } else { | ||
| $result = $this->validateValue($model->$attribute); | ||
| foreach ($files as $file) { | ||
| $result = $this->validateValue($file); |
samdark
pushed a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator does not modify the attribute anymore - it was filtering out non-uploaded-files values from the array so far, but only for the array typed attributes with maxFiles != 1 or minFiles > 1.
Setting max files != 1 and sending empty array does not ends in error.