Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20231: Fix regression introduced in #20167 in yii\validators\FileValidator #20233

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

bizley
Copy link
Member

@bizley bizley commented Jul 25, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #20231

@bizley bizley requested a review from a team July 25, 2024 11:23
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.94%. Comparing base (6abe5bf) to head (dd37f90).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20233      +/-   ##
============================================
- Coverage     64.94%   64.94%   -0.01%     
+ Complexity    11391    11390       -1     
============================================
  Files           430      430              
  Lines         36912    36912              
============================================
- Hits          23973    23972       -1     
- Misses        12939    12940       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added this to the 2.0.52 milestone Jul 25, 2024
@samdark samdark requested a review from a team July 25, 2024 17:49
@bizley bizley added the type:bug Bug label Jul 26, 2024
@arogachev arogachev requested review from a team July 26, 2024 14:03
@samdark samdark changed the title Fix regression in FileValidator Fix #20231: Fix regression introduced in #20167 in yii\validators\FileValidator Jul 26, 2024
@samdark samdark merged commit 0d0f775 into master Jul 26, 2024
160 of 168 checks passed
@samdark samdark deleted the 20231-file-validator-regression branch July 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants