-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dropping views in MSSQL server when running migrate/fresh #20257
Add support for dropping views in MSSQL server when running migrate/fresh #20257
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20257 +/- ##
============================================
- Coverage 64.96% 64.95% -0.01%
Complexity 11395 11395
============================================
Files 430 430
Lines 36922 36923 +1
============================================
- Hits 23985 23982 -3
- Misses 12937 12941 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one. Thanks. Possible to add test for it?
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If no one else have objection, I will merge it!
@ambrozt Thanks for your time and efforts |
I think the function testRefreshMigration in yiiunit\framework\console\controllers\MigrateControllerTest should already cover this scenario, although I am not sure why the test is not being run on Microsoft SQL databases |
Add support for dropping views in MSSQL server when running migrate/fresh