Fix web-ext lint warning: UNSAFE_VAR_ASSIGNMENT

ylogx · May 18, 2019 · a48d573 · a48d573
1 parent 60f2b6b
commit a48d573
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/Makefile b/Makefile
@@ -1,2 +1,8 @@
 package:
 	zip -r BangDD-v0.1.0.zip *.js *.json *.md icons
+
+lint:
+	web-ext lint
+
+install_deps:
+	npm install --global web-ext
diff --git a/bangdd.js b/bangdd.js
@@ -30,11 +30,11 @@ function onTimeToBang(event) {
 }
 
 function createButton() {
-    let bang_it = createElementFromHTML(
-        '<li id="bang_it" class="zcm__item">' +
+    let div = document.createElement('div');
+    div.innerHTML = '<li id="bang_it" class="zcm__item">' +
         '<a data-zci-link="bang_it" class="zcm__link  js-zci-link  js-zci-link--bang_it" href="#">Google</a>' +
-        '</li>'
-    );
+        '</li>';
+    let bang_it = div.firstChild;
 
     bang_it.addEventListener("click", function (event) {
         (onTimeToBang).call(bang_it, event);
@@ -54,14 +54,6 @@ function insertInCorrectPosition(bang_it) {
 }
 
 /* Helper Methods */
-function createElementFromHTML(htmlString) {
-    let div = document.createElement('div');
-    div.innerHTML = htmlString.trim();
-
-    // Change this to div.childNodes to support multiple top-level nodes
-    return div.firstChild;
-}
-
 function insertAfter(el, referenceNode) {
     referenceNode.parentNode.insertBefore(el, referenceNode.nextSibling);
 }