Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft for bubble example working #100

Merged
merged 29 commits into from
Aug 18, 2024
Merged

draft for bubble example working #100

merged 29 commits into from
Aug 18, 2024

Conversation

yoctoyotta1024
Copy link
Owner

bubble example with tmp script working.

bug fixes to yac coupling:

  • ensuring correct timesteps are used in yac_bubble_data_reader.py.
  • latitudes, longitudes, size of domain and vertical levels of CLEO grid are consistent with itself and ICON grid.
  • fixed order of indexing when filling target_array in yac dynamics.
  • data in ICON put called is correctly sliced and flipped since ICON vertical levels go from top to bottom not bottom to top.

still need to make tmp script conform with other examples and refine steps to setup configuration.

@yoctoyotta1024
fix: correct python path for yac
55cd54f
@yoctoyotta1024
fix: correct gridfile for bubble
dd09574
@yoctoyotta1024
fix: don't activate cleoenv during compilation
b2f2946
@yoctoyotta1024
feat: chose file for ICONN data fom arguments passed to python script
259ab37
@yoctoyotta1024
refactor: make yac script compatible with Torus Triangles gridfile
ad01628
@yoctoyotta1024
chore: formatting
e1df3b3
@yoctoyotta1024
refactor: change obsstep, coupling step and add another superdroplet …
cd7fc9d 
…observer
@yoctoyotta1024
refactor: remove make clean from tmp file
dda8571
@yoctoyotta1024
chore: formatting
33c97c9
@yoctoyotta1024
chore: formatting
e0c2cae
@yoctoyotta1024
refactor: make yac_bubble_data_reader python script more general + fo…
8f8b6bf 
…rmatting
@yoctoyotta1024
fix: minor bug fixes for typos and naming types for args into script
70914cf
@yoctoyotta1024
refactor: make ICON grid name an input variable and aadded print stat…
7ffa41d 
…ement
@yoctoyotta1024
refactor: make ICON grid name an input variable and aadded print stat…
cbc9c21 
…ement
@yoctoyotta1024
fix: use correct grid in tmp run script
63e5fe2
@yoctoyotta1024
refactor: reorganise tmp run script for clarity
e4a2bf7
@yoctoyotta1024
refactor: change grid for cleo in bubble3d example
f1d9d9f
@yoctoyotta1024
fix: ensure gbxidxs for plotting are ints
1ff8812
@yoctoyotta1024
fix: ensure gbxidxs for plotting are ints
2e4a1a9
@yoctoyotta1024
fix: minor variable renaming
67ca555
@yoctoyotta1024
refactor: demand that yac is given max and min longitude and latitude…
3e67b02 
… in config params
@yoctoyotta1024
fix: add missin types
f598954
@yoctoyotta1024
chore: formatting
bdc10d1
@yoctoyotta1024
fix: correct ordering of yac_raw_data into target_array for each vari…
3a111f5 
…able
@yoctoyotta1024
refactor: reorganise functionality to remove case switch
e74a3f2
@yoctoyotta1024
fix: correctly slice icon data to account for vertical levels being t…
981f486 
…op down not bottom up
@yoctoyotta1024
chore: extend bubble example run time
33c9cbb
@yoctoyotta1024
refactor: set good params for bubble example
df9f137
@yoctoyotta1024
refactor: bubble with higher resolution settings
d5a026c
@yoctoyotta1024 yoctoyotta1024 merged commit 234942c into main Aug 18, 2024
7 checks passed
@yoctoyotta1024 yoctoyotta1024 deleted the bubble branch August 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoctoyotta1024