safePerformance for performance-canvas (#1487) #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make dict moving faster and save scroll location * Replace dictionaryInfoMap with find * Replace cleanup loop with map * Make for loop sane
…vs#1675) * Fix constant error on firefox mobile from chrome.contextMenus * Put if check over whole block * Split out into separate method so it can early return
…1677) * Disallow the use of performance * Add safePerformance * Replace all performance with safePerformance * Disconnect safePerformance from Performance due to constructor issues * Fix missing import * Add safe-performance to eslintrc * Ignore errors for using performance in dev directory * Add missing imports
…ance-canvas # Conflicts: # ext/js/display/display.js
CodSpeed Performance ReportMerging #1678 will degrade performances by 21.36%Comparing Summary
Benchmarks breakdown
|
Playwright test results
Details
Failed testschromium › visual.spec.js › visual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets the branch of #1487
Fixes merge conflicts from #1677
History here looks a little funky but when it's actually merged into the PR only 65ec09d and e80b3c3 should show since master already has the others.