Add SLSA provenance to releases #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themoeway-bot
approved these changes
Oct 1, 2023
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently our releases are not signed in any way, and as a result we fail the "Signed-Releases" check of the openssf scorecard.
What
Sign releases using the SLSA generic GitHub provenance generator.
This not only signs the release, but also generates evidence that the release was generated from the repository's GitHub workflow (as opposed to e.g., a malicious repo admin's computer who then uploaded it after).
This is even more powerful than a normal signature, because it means that it's possible for a user to entirely cryptographically verify & audit how the release artifacts were built.