Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that caused static framework target dependencies from having their default link value inferred as true #1110

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix issue that caused static framework target dependencies from having their default link value inferred as true #1110

wants to merge 4 commits into from

Commits on Jul 20, 2021

  1. Update TestProject fixture to static framework targets with dependenc… 

    …ies to dynamic framework targets to reproduce bug
    @liamnichols
    liamnichols committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1f391f1 View commit details
    Browse the repository at this point in the history

  2. Update PBXProjGenerator to detect proper defaiult link value for targ… 

    …et dependencies where the dependency is a static framework (not library)
    @liamnichols
    liamnichols committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    159f719 View commit details
    Browse the repository at this point in the history

  3. Regerate fixtures after applying the fix

    @liamnichols
    liamnichols committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    8e19482 View commit details
    Browse the repository at this point in the history

  4. Update documentation in ProjectSpec.md

    @liamnichols
    liamnichols committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    88ae010 View commit details
    Browse the repository at this point in the history