Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed loadPlaylist and cuePlaylist private methods. #283

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed loadPlaylist and cuePlaylist private methods. #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57107f6
Removed loadPlaylist and cuePlaylist private methods.
rlustemberg Jul 5, 2017
c41c24c
Replace usage of UIWebView with WKWebView
Nov 5, 2018
62e76b6
Fix issue with author's icon and title
Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions Classes/YTPlayerView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

#import <UIKit/UIKit.h>
#import <WebKit/WebKit.h>

@class YTPlayerView;

Expand Down Expand Up @@ -138,9 +139,9 @@ typedef NS_ENUM(NSInteger, YTPlayerError) {
* YTPlayerView::loadWithPlaylistId: or their variants to set the video or playlist
* to populate the view with.
*/
@interface YTPlayerView : UIView<UIWebViewDelegate>
@interface YTPlayerView : UIView<WKNavigationDelegate>

@property(nonatomic, strong, nullable, readonly) UIWebView *webView;
@property(nonatomic, strong, nullable, readonly) WKWebView *webView;

/** A delegate to be notified on playback events. */
@property(nonatomic, weak, nullable) id<YTPlayerViewDelegate> delegate;
Expand All @@ -150,8 +151,8 @@ typedef NS_ENUM(NSInteger, YTPlayerError) {
* This is a convenience method for calling YTPlayerView::loadPlayerWithVideoId:withPlayerVars:
* without player variables.
*
* This method reloads the entire contents of the UIWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire UIWebView, use the
* This method reloads the entire contents of the WKWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire WKWebView, use the
* YTPlayerView::cueVideoById:startSeconds:suggestedQuality: family of methods.
*
* @param videoId The YouTube video ID of the video to load in the player view.
Expand All @@ -164,8 +165,8 @@ typedef NS_ENUM(NSInteger, YTPlayerError) {
* This is a convenience method for calling YTPlayerView::loadWithPlaylistId:withPlayerVars:
* without player variables.
*
* This method reloads the entire contents of the UIWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire UIWebView, use the
* This method reloads the entire contents of the WKWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire WKWebView, use the
* YTPlayerView::cuePlaylistByPlaylistId:index:startSeconds:suggestedQuality:
* family of methods.
*
Expand All @@ -187,8 +188,8 @@ typedef NS_ENUM(NSInteger, YTPlayerError) {
* both strings and integers are valid values. The full list of parameters is defined at:
* https://developers.google.com/youtube/player_parameters?playerVersion=HTML5.
*
* This method reloads the entire contents of the UIWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire UIWebView, use the
* This method reloads the entire contents of the WKWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire WKWebView, use the
* YTPlayerView::cueVideoById:startSeconds:suggestedQuality: family of methods.
*
* @param videoId The YouTube video ID of the video to load in the player view.
Expand All @@ -210,8 +211,8 @@ typedef NS_ENUM(NSInteger, YTPlayerError) {
* both strings and integers are valid values. The full list of parameters is defined at:
* https://developers.google.com/youtube/player_parameters?playerVersion=HTML5.
*
* This method reloads the entire contents of the UIWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire UIWebView, use the
* This method reloads the entire contents of the WKWebView and regenerates its HTML contents.
* To change the currently loaded video without reloading the entire WKWebView, use the
* YTPlayerView::cuePlaylistByPlaylistId:index:startSeconds:suggestedQuality:
* family of methods.
*
Expand Down
Loading