enhance: simulator can't change sensor position, viewer can.

yushiang-demo · May 5, 2024 · 56f4576 · 56f4576
1 parent 7b9c105
commit 56f4576
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/Simulator.jsx b/src/Simulator.jsx
@@ -117,12 +117,10 @@ const Simulator = () => {
     };
 
     window.addEventListener("resize", core.resizeCanvas);
-    canvas.addEventListener("pointerdown", core.onSelectSensor);
     canvas.addEventListener("pointerup", onPointerUp);
 
     return () => {
       window.removeEventListener("resize", core.resizeCanvas);
-      canvas.addEventListener("pointerdown", core.onSelectSensor);
       canvas.removeEventListener("pointerup", onPointerUp);
     };
   }, [core, isTeleport, isPause]);

diff --git a/src/Viewer.jsx b/src/Viewer.jsx
@@ -12,6 +12,7 @@ const Viewer = () => {
     const threeApp = new ThreeApp(canvas);
 
     window.addEventListener("resize", threeApp.resizeCanvas);
+    canvas.addEventListener("pointerdown", threeApp.onSelectSensor);
 
     let prevPosition = [0, 0, 0];
     const timer = setInterval(() => {
@@ -41,15 +42,19 @@ const Viewer = () => {
             sensorPositions.map((v) => v.toArray()),
             sensorDistance
           );
-          threeApp.setCamera(prevPosition, result);
-          prevPosition = [...result];
+
+          if (JSON.stringify(prevPosition) !== JSON.stringify(result)) {
+            threeApp.setCamera(prevPosition, result);
+            prevPosition = [...result];
+          }
         });
     }, 2e2);
 
     return () => {
       clearInterval(timer);
       threeApp.animator.dispose();
       window.removeEventListener("resize", threeApp.resizeCanvas);
+      canvas.addEventListener("pointerdown", threeApp.onSelectSensor);
     };
   }, []);