-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress test for opaAuthorizeRequest filter #8575
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Cannot start a pipeline due to:
Click on pipeline status check Details link below for more information. |
Cannot start a pipeline due to:
Click on pipeline status check Details link below for more information. |
Cannot start a pipeline due to:
Click on pipeline status check Details link below for more information. |
Cannot start a pipeline due to:
Click on pipeline status check Details link below for more information. |
@@ -318,6 +340,230 @@ pipeline: | |||
cpu: 500m | |||
memory: 1Gi | |||
|
|||
- id: create-opa-enabled-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't like that we create another cluster in the pipeline; It will add another 30m to each PR, but that's for teapot to decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR time
Total steps runtime: 1 h, 34 m, 26 s
other PR times (went through 5 not all all of them)
Total steps runtime: 1 h, 8 m, 47 s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. I understand that it would be a concern. Will wait for Teapot's feedback for that. However we do not hope to keep these steps forever. It's only until we are confident enough to enable this feature for all the clusters.
Also the overall completion time for a build is not affected as these 3 steps run parallel to other create-cluster, e2e steps.
Changes
Skipper rbac configuration is ordered to be applied before deployment to make sure the service account is created before the deployment.
Add three new steps in delivery.yaml
create-opa-enabled-cluster: creates a new cluster using the same configuration + manifests as the
create-cluster
step. The only difference in the configuration isskipper_open_policy_agent_enabled
flag value. The CLUSTER_ALIAS and LOCAL_ID is adjusted so that it does not conflict with the e2e cluster that is created withcreate-cluster
step.opa-e2e-tests: Run the e2e test for
opaAuthorizeRequest
filterdecommission-opa-enabled-cluster: Decommissions the opa enabled cluster
Change
test/e2e/run_e2e.sh
to enable different variation of cluster_creation, e2e testing and cluster_decommissioning.opaAuthorizeRequest is initialized and verified in tests