add initJob.podSpec #298
Merged
add initJob.podSpec #298
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monotek
requested changes
Oct 7, 2024
mgruner
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Looks good to me!
Do you think we could add this to init-podspec/zammad/ci/full-values.yaml? This file is used in CI by chart-testing to create a cluster with a lot of possible value customizations to ensure it can still be installed and started properly?
|
@mgruner I added podSpec activeDeadlineSeconds 1337 or should I use other example values? |
monotek
previously approved these changes
Oct 14, 2024
mgruner
requested changes
Oct 15, 2024
mgruner
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds podSpec to the initJob
Which issue this PR fixes
With this PR I can add
and fix #297
Checklist