Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql extension #482

Closed
wants to merge 85 commits into from
Closed

Update sql extension #482

wants to merge 85 commits into from

Conversation

nervenes
Copy link
Contributor

@nervenes nervenes commented Apr 12, 2024

Copy link

cla-bot bot commented Apr 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Evren Sen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Apr 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Evren Sen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Apr 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Evren Sen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@nervenes
Copy link
Contributor Author

My email is set up, what is wrong here?

@nervenes nervenes marked this pull request as draft April 12, 2024 08:29
@maxdeviant
Copy link
Member

My email is set up, what is wrong here?

These old commits appear to have the wrong author attribution on them:

Screenshot 2024-04-12 at 7 38 09 AM

@nervenes
Copy link
Contributor Author

Thanks for reaching out! Sorry, I don't know how to fix this

Copy link

cla-bot bot commented Apr 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Evren Sen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Evren Sen and others added 19 commits April 13, 2024 16:51
Updates the extension to use the [freshly
documented](zed-industries@6ab7d42)
extension.toml format instead of extension.json.

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
- Amends git modified to use dracula convention colors (cyan)
- Fixes interaction states on ghost elements
- Adds correct styles for active wrap guides
- Amends scrollbar to be less janky
- Amends terminal background to be darker
- Amends predictive colors

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
This PR updates the extension CI to cache the `zed-extension` CLI and
only download it from the blob store when needed.

I've been seeing some slow, multi-minute downloads every once in a
while, so it seems like the caching may be worth it.
Port of [Oceanic Next Color
Scheme](https://github.com/voronianski/oceanic-next-color-scheme) with
slight changes. Personally my favorite dark theme and it seems that
others might agree too zed-industries#28!
Changes:

- change warning and error colors
tsimoshka/zed-theme-alabaster@817ab28
- migrate from extension.json to extension.toml
tsimoshka/zed-theme-alabaster@53bb59e
Dark theme with purple and blue as main colors, as you can see on my
Github profile, my favorites :P

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
This PR adds the PHP extension.

PHP support was extracted from Zed in
zed-industries/zed#9966.
closes zed-industries#196

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
This PR adds the C# extension.

C# support was extracted from Zed in
zed-industries/zed#9971.
I mostly copied the gleam extension, and I believe this works well,
however I would love some feedback on the extension's code.

And how important is it to support aarch platforms? I only support
x86_64 right now
This PR updates the cache key we use for the `zed-extension` binary to
have some additional context than just the Git SHA.
- closes zed-industries/zed#10024
- use `extension.toml` instead of `extension.json`
Oops! zed-industries#420

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Evren Sen added 22 commits April 13, 2024 16:51
This PR updates the TOML extension to v0.1.0.

See zed-industries/zed#10482 for the changes in
this version.
This PR adds the Elm extension.

Elm support was extracted from Zed in
zed-industries/zed#10432.
This PR adds the GLSL extension.

GLSL support was extracted from Zed in
zed-industries/zed#10433.
This PR adds the Scheme extension.

Scheme support was extracted from Zed in
zed-industries/zed#10442.
This PR adds the Racket extension.

Racket support was extracted from Zed in
zed-industries/zed#10442.
This PR updates the Emmet extension to v0.0.2.

This version of the extension adds support for PHP and ERB files with
Emmet (when using Zed v1.131.0 and above).
This PR adds the Lua extension.

Lua support was extracted from Zed in
zed-industries/zed#10437.
This PR adds the OCaml extension.

OCaml support was extracted from Zed in
zed-industries/zed#10450.
- Remove Redrum theme
- Increase remaining themes' background opacity from #xxxxxx77 to
#xxxxxxAA
This PR adds the Terraform extension.

Terraform support was extracted from Zed in
zed-industries/zed#10479.

Note that the Terraform extension requires Zed v0.132.x (which will be
released this coming Wednesday) in order for some problematic code
action kinds to be filtered out from the language server.
This PR adds the Vue extension.

Vue support was extracted from Zed in
zed-industries/zed#10486.

Note that the Terraform extension requires Zed v0.132.x (which will be
released this coming Wednesday) in order for some problematic code
action kinds to be filtered out from the language server.
This PR adds a warning when an `extension.json` manifest is detected.

`extension.toml` should be preferred instead.
Copy link

cla-bot bot commented Apr 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Evren Sen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@nervenes
Copy link
Contributor Author

nervenes commented Apr 13, 2024

Sorry, i give up on this, having very difficult times trying to fix this.

Edit: I tried rebasing with this command git rebase -r 071dc9d9c1216908944e61a05d181ca9631ff43c --exec 'git commit --amend --no-edit --reset-author' which as it seems messed things up even more.

@nervenes nervenes closed this Apr 13, 2024
@maxdeviant maxdeviant mentioned this pull request Apr 16, 2024
maxdeviant added a commit that referenced this pull request Apr 16, 2024
This PR updates the SQL extension to v1.0.0.

This is a continuation of
#482.

cc @evrsen
cabrinha pushed a commit to cabrinha/extensions that referenced this pull request Aug 9, 2024
This PR updates the SQL extension to v1.0.0.

This is a continuation of
zed-industries#482.

cc @evrsen
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
This PR updates the SQL extension to v1.0.0.

This is a continuation of
zed-industries#482.

cc @evrsen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants