Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serendipity to v0.0.4 #790

Merged
merged 5 commits into from
May 30, 2024
Merged

Update serendipity to v0.0.4 #790

merged 5 commits into from
May 30, 2024

Conversation

meocoder31099
Copy link
Contributor

@meocoder31099 meocoder31099 commented May 26, 2024 •
edited
Loading

  • add new theme variant Midnight Minimal
  • add new no italic theme variant
  • Increase contrast
  • Add color support for indent guides (Zed v0.138.0-pre and above)

@cla-bot cla-bot bot added the cla-signed label May 26, 2024
maxdeviant
maxdeviant requested changes May 28, 2024
View reviewed changes
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like now there are two different theme files that both define a theme family with the name Serendipity.

Could you either combine these all into a single file or change one of the family names to be different?

@meocoder31099
Copy link
Contributor Author

It looks like now there are two different theme files that both define a theme family with the name Serendipity.

Could you either combine these all into a single file or change one of the family names to be different?

Is it mandatory to use different names?
Basically, both files are just different variations of Serendipity. I separated them into two files to make management and maintenance easier.

@meocoder31099 meocoder31099 requested a review from maxdeviant May 28, 2024 16:06
@maxdeviant
Copy link
Member

It looks like now there are two different theme files that both define a theme family with the name Serendipity.
Could you either combine these all into a single file or change one of the family names to be different?

Is it mandatory to use different names? Basically, both files are just different variations of Serendipity. I separated them into two files to make management and maintenance easier.

Today I think what you are doing will work, but it's not how the theme system was designed, and it will cause problems for your theme down the line.

@meocoder31099
Copy link
Contributor Author

I have chosen to rename the theme family. I wonder which option is more ideal: renaming them or merging them into a single file?

@meocoder31099 meocoder31099 changed the title Update serendipity to v0.0.3 Update serendipity to v0.0.4 May 30, 2024
@maxdeviant maxdeviant merged commit cac228c into zed-industries:main May 30, 2024
2 checks passed
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
@meocoder31099
Update serendipity to v0.0.4 (zed-industries#790)
1d5244d 
- add new theme variant Midnight Minimal
- add new no italic theme variant
- Increase contrast
- Add color support for indent guides (Zed v0.138.0-pre and above)
@koozz koozz mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxdeviant maxdeviant maxdeviant approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meocoder31099 @maxdeviant