Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Green Monochrome Monitor CRT Phosphor theme #816

Merged
merged 5 commits into from
May 31, 2024
Merged

Add Green Monochrome Monitor CRT Phosphor theme #816

merged 5 commits into from
May 31, 2024

Conversation

Takk8IS
Copy link
Contributor

@Takk8IS Takk8IS commented May 30, 2024

📺 This PR adds the Green Monochrome Monitor CRT Phosphor theme for Zed.

@cla-bot cla-bot bot added the cla-signed label May 30, 2024
@Takk8IS
Copy link
Contributor Author

Takk8IS commented May 31, 2024

Dear @maxdeviant, what happened now? 😟

@Moshyfawn
Copy link
Member

  • See the structure section for how to provide your extension's config, and what entries are expected there.

  • You also never added your themes repo as a submodule of this repo in the extensions subfolder; the submodule field in the extensions config should be the path to the submodule, as it's not just the name of your extension.

  • If you could sort your extensions.toml extension entry alphabetically, that would also be great, thanks!

@maxdeviant maxdeviant changed the title 💾 Add Green Monochrome Monitor CRT Phosphor theme Add Green Monochrome Monitor CRT Phosphor theme May 31, 2024
@maxdeviant
Copy link
Member

@Takk8IS I noticed your extension has both extension.json and extension.toml.

We only need extension.toml, the extension.json is the legacy format.

@Takk8IS
Copy link
Contributor Author

Takk8IS commented May 31, 2024

@Moshyfawn @maxdeviant Ah ok, got it. Thank you for helping me. I'm not used to using PRs, is everything OK and approved now to publish the theme or should I do the procedure again?

@maxdeviant
Copy link
Member

@Moshyfawn @maxdeviant Ah ok, got it. Thank you for helping me. I'm not used to using PRs, is everything OK and approved now to publish the theme or should I do the procedure again?

You just need to remove the extension.json file from here https://github.com/Takk8IS/green-monochrome-monitor-crt-phosphor-theme-for-zed/blob/main/extension.json and then I can update the submodule and it will be ready to publish.

@Takk8IS
Copy link
Contributor Author

Takk8IS commented May 31, 2024

@maxdeviant done =)

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant merged commit 2556739 into zed-industries:main May 31, 2024
2 checks passed
@maxdeviant maxdeviant mentioned this pull request Jul 1, 2024
1 task
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
📺 This PR adds the Green Monochrome Monitor CRT Phosphor theme for Zed.

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants