Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ProcConf to make SetTimeToForceQuit configurable #4446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WqyJh
Copy link
Contributor

@WqyJh WqyJh commented Nov 4, 2024

Add ProcConf to ServiceConf, then we can use config file instead of SetTimeToForceQuit to set force quit time.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (8690859) to head (54bae6e).
Report is 159 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
core/proc/shutdown.go 75.51% <100.00%> (+1.59%) ⬆️
core/service/serviceconf.go 90.32% <100.00%> (+0.32%) ⬆️

... and 4 files with indirect coverage changes

@WqyJh
Copy link
Contributor Author

WqyJh commented Nov 14, 2024

Could this simple patch be merged? @kevwan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant