loongarch: Add SLJIT_UPPER_BITS_SIGN_EXTENDED #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that in LoongArch V1.1 (LA664 and later), the SLJIT_UPPER_BITS_IGNORED should also be true, however due to a micro-architecture bug, 3A5000 (LA464) will needs the upper 32 bits of source register is sign extended while doing 32 bits division (e.g. div.w), otherwise it will output garbage result. See: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html Chapter 1.5.1 Item 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that in LoongArch V1.1 (LA664 and later), the SLJIT_UPPER_BITS_IGNORED should also be true, however due to a micro-architecture bug, 3A5000 (LA464) will needs the upper 32 bits of source register is sign extended while doing 32 bits division (e.g. div.w), otherwise it will output garbage result.
See: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html Chapter 1.5.1 Item 7
Also: https://areweloongyet.com/newsletter/this-week-in-loongarch-22 (Chinese Only)
Done: #232