Configurably Disable OpenAI -> Gemini Model Mapping #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new environment variable, DISABLE_MODEL_MAPPING, when enabled removes the OpenAI -> Gemini Model mapping and provides access to the named gemini models directly. Moved model mapping logic to its own `models.go` file inside the adapter package. Additionally, fixed a bug where responses would return the gemini model name even though model mapping was enabled.
|
@zhu327 Here is the cleaned up version of disabled model mapping |
zhu327
approved these changes
Aug 8, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new environment variable,
DISABLE_MODEL_MAPPING, when enabled removes the OpenAI -> Gemini Model mapping and and directly exposes the underlying gemini models in the api endpoints.Moved model mapping logic to its own
models.gofile inside the adapter package. Additionally, fixed a bug where responses would return the gemini model name even though model mapping was enabled.My previous PR (#38) had some extraneous changes and disabled model mapping by default. This change provides that functionality in a configurable way, better addressing #35 and contains no breaking changes for preexisting setups.