Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file manager #422

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add a file manager #422

wants to merge 12 commits into from

Conversation

Eddy-Barraud
Copy link

I added a php file manager.
In order to access folders and files in your pc, you must create a Symbolic link in the folder.

@no1xsyzy
Copy link
Contributor

no1xsyzy commented Dec 27, 2017

Why you change bootstrap css file?
You require php and nginx or apache to make that possible: too heavy for a normal user.
Password change is real disaster: md5sum is not safe but difficult to use.
What's more, tinyfilemanager.php is licensed under GPLv3, which is not compatible with MIT license. As contributor of this project, I disagree to release it under GPLv3. (For issues about invention)

And I strongly disapprove file manager constructed inside. This must be constructed outside of it, out of control of aria2. I mean a page with frames and change frame of download manager and file manager is way more better. For example (can achieve better style with proper css):

<!-- index.html -->
<html>
<head><!-- head stuff here --></head>
<frameset rows="10%,90%"> <!-- instead of body, use frameset -->
<frame src="nav.html"></frame>
<frame name="slot"></frame>
</frameset>
</html>

<!-- nav.html -->
<html>
<head><!-- head stuff here --></head>
<body>
<a href="webui-aria2/index.html" target="slot">Download Manager</a>
<a href="file-manager/" target="slot">File Manager</a>
</body>
</html>

achieves both decoupling and simplicity.

@Eddy-Barraud
Copy link
Author

Ups, sorry for the tinyfilemanager, I saw that license and i chose Simple PHP File Manager by John Campbell but i forgot to remove the file ! xD
I'll try the frames, good idea ;)

@Eddy-Barraud
Copy link
Author

Arf, I saw that "The tag is not supported in HTML5." .... It's too long for me to use Ajax .... or other things, i let it like that. Sry
And i changed the CSS to make modules have a 80% width.

@no1xsyzy
Copy link
Contributor

You should also provide more documents on the file manager, including a warning of complexity.
Configuring PHP + Nginx/Apache to work with your solution might be beyond many user's ability, so you should include a tutorial with sample configuration files.
And with file manager, there are more CPU and memory usage.
Modifying bootstrap.css is not good: you are modifying a minified css and stops git (based on line) to work well. Change css/style.css or other unminified css instead.

I advise Electron native apps for file management with download management. There is an open issue for it but no progress so far.

@ziahamza
Copy link
Owner

I agree with @no1xsyzy that setting up webui with apache and php is not everyones take. Perhaps we can make WebUI work better with static file servers, so it can directly have a download / preview button to open the url in a file explorer in a new tab ... that way users can setup file manager separately

@ziahamza
Copy link
Owner

But I am more then happy to check in different packages (in PHP & perhaps NodeJS) to give more functionality.

And electron apps would be a killer :D

Native downloading cross platform

@anthonyraymond
Copy link
Collaborator

anthonyraymond commented Jun 9, 2018

I've managed to run a java app and it's web ui in an electron app.
If you want to take a look : https://github.com/anthonyraymond/joal-desktop

In my case the java app embed the Webui, it will be slightly different to have it externalized, but it won't be a big deal to adapt.
In case it might help someone to start bundling this into an electron app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants