-rdynamic/--export-dynamic fixes #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Mar 28, 2020
| @@ -768,6 +768,11 @@ static int main0(int argc, char **argv) { | |||
| return EXIT_FAILURE; | |||
| } | |||
| dynamic_linker = buf_ptr(linker_args.at(i)); | |||
| } else if (buf_eql_str(arg, "-E") || | |||
There was a problem hiding this comment.
Why -E? for a C compiler it means "preprocessor only". I'm hesitant to overload that meaning.
There was a problem hiding this comment.
To be more clear, since I realized I didn't include this in the OP:
This is meant to fix warning: unsupported linker arg: --export-dynamic when doing zig cc -Wl,--export-dynamic or zig cc -Wl,-E (or other ways of passing linker args like --for-linker, but those aren't supported by zig cc yet). Full context is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--export-dynamicnot getting set via-rdynamicin the ELF linker construction seems to have been a bug? Correct me if I'm wrong, or if-rdynamicshould be handled in any of the other linker formats (right nowZigLLVM_MachOsends-export_dynamicand with this PRZigLLVM_ELFsends--export-dynamic;ZigLLVM_WasmandZigLLVM_COFFignore-rdynamic).-rdynamicand-Wl,--export-dynamicare essentially the same thing with regards to Zig. The difference in other compilers is that-rdynamicdoesn't set--export-dynamicif it doesn't need to for the target? If so, it seems like Zig would probably want to treat the--export-dynamiclinker flag the same as-rdynamic(hence why I made the--export-dynamiclinker flag setrdynamic = trueinzig ccinstead of adding a separateexport_dynamicfield).Contributes towards #4784
EDIT: