Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ZHA units and unit validation #332

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

cfulton
Copy link

@cfulton cfulton commented Dec 19, 2024

This is an alternative to PR #331

Breaking Change:

  • Any quirks that use the ZHA units will need to be updated to use a string value of the unit or to use the homeassistant const units enums instead.

This PR:

  • Removed unit definitions from ZHA
  • Updated references to units from HA instead
  • Removed validate units on quirks

Should resolve the following issues:

@cfulton
Copy link
Author

cfulton commented Dec 19, 2024

a0e2b93

This commit is in case we do not want to have a dependency on home assistant.

Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to completely remove units. The issue is that they're duplicated in both quirks v2 in zigpy and in ZHA right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants