print packet when ZDO packet deserialize fails #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keep in mind that these deserialization failures are entirely inconsequential, Z-Stack does its own processing of ZDO and we haven't created handlers for all of the possible ways the ZDO commands can be parsed by Z-Stack. This is because we don't actually care about these and zigpy does its own processing on the raw packet. We just can't stop Z-Stack from sending its own commands as well. I think you should just change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a on_zdo_message deserialize issue, it would be great to get the packet printed in order to get more information.
Especially having the 2 bytes of the message will indicate the status.