refactor: simplify overly verbose code

zkLend · Sep 19, 2023 · b767531 · b767531
1 parent e3e6226
commit b767531
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/libraries/ownable.cairo b/src/libraries/ownable.cairo
@@ -62,7 +62,6 @@ fn transfer_ownership<T, impl TOwnable: Ownable<T>, impl TDrop: Drop<T>>(
 fn renounce_ownership<T, impl TOwnable: Ownable<T>, impl TDrop: Drop<T>>(ref self: T) {
     assert_only_owner(@self);
     __private::_transfer_ownership(ref self, contract_address_const::<0>());
-    return ();
 }
 
 // Not public API (Cairo does not support _real_ private modules yet)

diff --git a/src/z_token/view.cairo b/src/z_token/view.cairo
@@ -36,10 +36,7 @@ fn decimals(self: @ContractState) -> felt252 {
 }
 
 fn totalSupply(self: @ContractState) -> u256 {
-    let scaled_up_supply = felt_total_supply(self);
-    let scaled_up_supply: u256 = scaled_up_supply.into();
-
-    scaled_up_supply
+    felt_total_supply(self).into()
 }
 
 fn felt_total_supply(self: @ContractState) -> felt252 {
@@ -52,10 +49,7 @@ fn felt_total_supply(self: @ContractState) -> felt252 {
 }
 
 fn balanceOf(self: @ContractState, account: ContractAddress) -> u256 {
-    let scaled_up_balance = felt_balance_of(self, account);
-    let scaled_up_balance: u256 = scaled_up_balance.into();
-
-    scaled_up_balance
+    felt_balance_of(self, account).into()
 }
 
 fn felt_balance_of(self: @ContractState, account: ContractAddress) -> felt252 {