Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Centos6/7 compilation issues #469

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Fix for Centos6/7 compilation issues #469

merged 8 commits into from
Mar 12, 2024

Conversation

greenozon
Copy link
Contributor

Centos6/7 uses very old gcc/g++ so some alignments should be done in order to support it
those are minor AFAIK
Fixes issue #304

After this PR the output on Centos7 is as follows:

image

CMakeLists.txt Outdated Show resolved Hide resolved
@greenozon greenozon requested a review from zrax March 11, 2024 20:56
@zrax
Copy link
Owner

zrax commented Mar 11, 2024

Well, there certainly are a lot more of those than I expected... I think I've changed my mind, and would prefer -Wno-error=shadow, so they still show up as warnings, but won't block compilation.

@greenozon
Copy link
Contributor Author

@zrax addressed your request

@zrax zrax merged commit 6467c2c into zrax:master Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants