Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use untagged variants for Logger + relay_resolver.error support #483

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Use untagged variants for Logger + relay_resolver.error support #483

merged 2 commits into from
Jan 2, 2024

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Jan 1, 2024

Solves #478

zth
zth approved these changes Jan 1, 2024
View reviewed changes
Copy link
Owner

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Mind adding a changelog?

@DZakh
Copy link
Contributor Author

DZakh commented Jan 2, 2024

Done, should it be marked as a breaking change in some way?

@zth zth merged commit 2f4bf9a into zth:master Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DZakh @zth