Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack bridge: Update Slack bridge with Events API. #826

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Slack bridge: Update Slack bridge with Events API. #826

wants to merge 5 commits into from

Commits on Oct 20, 2024

  1. slack bridge: Update doc for the new webhook based Slack Bridge. 

    This commit updates the Slack Bridge doc, primarily
guiding the user to use our Slack Webhook integration.
    @PieterCK
    PieterCK committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    306261c View commit details
    Browse the repository at this point in the history

  2. slack bridge: Remove the legacy RTM API based bridge. 

    Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based we preivouslt use.
    @PieterCK
    PieterCK committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    78f5df4 View commit details
    Browse the repository at this point in the history

  3. slack bridge: Add logic to prevent looping messages. 

    When using Slack Webhook integration to get messages from Slack to
Zulip, we don't want to send back messages from the Slack integration
bot.

This prevents that by filtering out any messages from the Slack Webhook
bots when sending messages from Zulip to Slack..

Fixes zulip#825.
    @PieterCK
    PieterCK committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    ea6923e View commit details
    Browse the repository at this point in the history

  4. test workflow: Upgrade Python version to 3.10. 

    This is an optional commit that upgrade the Python
version for github workflows when running tests.
This commit doesn't try to drop support for
Python 3.8.
    @PieterCK
    PieterCK committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d4c5ad4 View commit details
    Browse the repository at this point in the history

  5. salesforce bot: Suppress mypy rising linting error. 

    This is an optional commit that ignores linting errors
in an unrelated file from zulip#826.
    @PieterCK
    PieterCK committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b4bcbf0 View commit details
    Browse the repository at this point in the history