Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert codebase to TypeScript. #92

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sundargs2000
Copy link

@sundargs2000 sundargs2000 commented Mar 22, 2021

Just the initial draft. Most of the interfaces are copied from this PR. Tasks left would be:

  1. Cross check the interfaces and add other API endpoints which aren't currently present.
  2. Write unit tests - either jest/mocha?
  3. Check if typescipt plugin for babel can be leveraged.
  4. Configure typescipt-eslint.

As of now, I have just manually tested some endpoints. Please let me know if this and the next steps look right.

@sundargs2000 sundargs2000 marked this pull request as draft March 31, 2021 16:07
@andersk
Copy link
Member

andersk commented Mar 31, 2021

Changing everything at once makes this difficult to review since the diffs don’t line up at all. We should do the conversion in multiple steps: first convert CommonJS modules to ES6 modules, one at a time, then convert ES6 modules to TypeScript, one at a time. Any major formatting changes should also be separated into their own commits. The .js files generated from .ts files should not be committed to the repository.

@sundargs2000 sundargs2000 reopened this Apr 3, 2021
@sundargs2000
Copy link
Author

@andersk Thank you for the inputs. As the first step, I have converted the modules from CommonJS to ES6. Have a look.

@limpep
Copy link

limpep commented May 8, 2023

+1

@Fabioni
Copy link

Fabioni commented Aug 29, 2024

@sundargs2000 what is the current status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants