Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum thread support #111

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Forum thread support #111

merged 5 commits into from
Nov 11, 2024

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Nov 6, 2024

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9136859) to head (3de6c22).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
zyte_common_items/pages/forum_thread.py 0.00% 25 Missing ⚠️
zyte_common_items/items/forum_thread.py 0.00% 14 Missing ⚠️
zyte_common_items/components/forum_thread.py 0.00% 6 Missing ⚠️
zyte_common_items/components/__init__.py 0.00% 1 Missing ⚠️
zyte_common_items/components/social_media_post.py 0.00% 1 Missing ⚠️
zyte_common_items/items/__init__.py 0.00% 1 Missing ⚠️
zyte_common_items/pages/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #111    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         58      63     +5     
  Lines       2236    2353   +117     
======================================
- Misses      2236    2353   +117     
Files with missing lines Coverage Δ
zyte_common_items/__init__.py 0.00% <ø> (ø)
zyte_common_items/components/__init__.py 0.00% <0.00%> (ø)
zyte_common_items/components/social_media_post.py 0.00% <0.00%> (ø)
zyte_common_items/items/__init__.py 0.00% <0.00%> (ø)
zyte_common_items/pages/__init__.py 0.00% <0.00%> (ø)
zyte_common_items/components/forum_thread.py 0.00% <0.00%> (ø)
zyte_common_items/items/forum_thread.py 0.00% <0.00%> (ø)
zyte_common_items/pages/forum_thread.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@Gallaecio
Copy link
Contributor Author

It’s probably just laziness on my end, but I wonder if it makes sense to keep adding class-specific tests like those in test_components and test_items for every new component and item. What do you think?

@Gallaecio Gallaecio marked this pull request as ready for review November 8, 2024 16:04
@kmike
Copy link
Contributor

kmike commented Nov 8, 2024

I don't see a huge value in these tests.

@Gallaecio Gallaecio merged commit a41b394 into zytedata:main Nov 11, 2024
9 checks passed
@Gallaecio
Copy link
Contributor Author

(don’t ask why I did not include this in 0.25.0 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants