Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseSearchRequestTemplatePage, change SearchRequestTemplatePage #113

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Gallaecio
Copy link
Contributor

This is a backward-incompatible change that makes things more consistent with other, similar classes, and gives both classes access to the no_item_found() method from _BasePage.

@Gallaecio Gallaecio requested review from kmike and wRAR November 8, 2024 12:41
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9136859) to head (756029e).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
zyte_common_items/pages/search_request_template.py 0.00% 3 Missing ⚠️
zyte_common_items/pages/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #113   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         58      60    +2     
  Lines       2236    2285   +49     
=====================================
- Misses      2236    2285   +49     
Files with missing lines Coverage Δ
zyte_common_items/__init__.py 0.00% <ø> (ø)
zyte_common_items/pages/__init__.py 0.00% <0.00%> (ø)
zyte_common_items/pages/search_request_template.py 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@kmike kmike merged commit 60c38c7 into zytedata:main Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants