Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide page objects for easier overriding #63

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

Gallaecio
Copy link
Contributor

No description provided.

@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ October 4, 2023 15:11
@Gallaecio
Copy link
Contributor Author

@kmike Shall I go ahead with this approach for all other types?

zyte_common_items/pages.py Outdated Show resolved Hide resolved
@Gallaecio Gallaecio marked this pull request as ready for review October 5, 2023 10:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #63 (d657168) into main (b2f9b6d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head d657168 differs from pull request most recent head 235746f. Consider uploading reports for the commit 235746f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #63    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          8       8            
  Lines        873    1329   +456     
======================================
- Misses       873    1329   +456     
Files Coverage Δ
zyte_common_items/__init__.py 0.00% <ø> (ø)
zyte_common_items/pages.py 0.00% <0.00%> (ø)

tests/test_pages.py Outdated Show resolved Hide resolved
@Gallaecio Gallaecio merged commit 82d3a2f into zytedata:main Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants