test(action): add timeout to SSH server start #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtomicFS
force-pushed
the
fix/ssh-tunnel-timeout
branch
2 times, most recently
from
53e36e0 to
1f7308f
Compare
MDr164
reviewed
Dec 18, 2024
MDr164
force-pushed
the
fix/ssh-tunnel-timeout
branch
from
1f7308f to
57ef276
Compare
Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
MDr164
force-pushed
the
fix/ssh-tunnel-timeout
branch
from
57ef276 to
61be6cb
Compare
MDr164
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking into #470, I had a issue when the tests would take forever, especially the
TestOpenSSH. It would hang for 1 hour until thego test ... -timeout 60m ...timeout would cause the test to fail.So I made this timeout feature. I set it only to 5 seconds, but it should be fine I think.
This seems to be a problem in the new dagger
v0.15.1since the exact same problem is now in #474