-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiFab tutorial with pyamrex #95
Conversation
Looks super cool! Just a reminder, that if you want to add the example to the CI/CD testing, the method for build and test for the Python code is likely different than the existing examples. |
Sounds good, thanks! Yes, I'm not sure how tutorials are treated with respect to CI/CD testing in AMReX. I will probably discuss this with @WeiqunZhang or @atmyers during the next part of the NERSC hackathon later this week. |
@ax3l @RevathiJambunathan @kngott I think this is ready for review. The test now shows both ways to fill an array on a given box (NumPy operations and standard I'm also using the function |
I finalized the example TODO markers and added CI :) |
Documentation added as well :) |
@EZoni @atmyers @etpalmer63 ready to go :) |
@EZoni @atmyers @etpalmer63 @WeiqunZhang ping :) |
Thank you to @RevathiJambunathan, @oshapoval, @dpgrote, @kngott and @ax3l for the teamwork.
Rewrite the "MultiFab" guided tutorial using pyamrex. Outstanding questions marked as "TODO" comments.