Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword args to MultiFab copy methods #155

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

EZoni
Copy link
Contributor

@EZoni EZoni commented Jul 21, 2023

Add keyword arguments to the copy methods of the class MultiFab, following AMReX's naming conventions, see https://github.com/AMReX-Codes/amrex/blob/587542a395e4bd1991c3e731b289ca89fe43746e/Src/Base/AMReX_MultiFab.H#L487-L499:

    static void Copy (MultiFab&       dst,
                      const MultiFab& src,
                      int             srccomp,
                      int             dstcomp,
                      int             numcomp,
                      int             nghost);

    static void Copy (MultiFab&       dst,
                      const MultiFab& src,
                      int             srccomp,
                      int             dstcomp,
                      int             numcomp,
                      const IntVect&  nghost);

@ax3l ax3l added the component: documentation Improvements or additions to documentation label Jul 21, 2023
@ax3l ax3l self-requested a review July 21, 2023 16:28
@ax3l ax3l self-assigned this Jul 21, 2023
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✨

@ax3l ax3l enabled auto-merge (squash) July 21, 2023 17:03
@ax3l ax3l merged commit 0853cbf into AMReX-Codes:development Jul 21, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants