Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: Set GPS instance ID in the GPS frame ID #28441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Oct 21, 2024

Purpose

Match battery behavior by setting the GPS instance number in the frame ID.

Other changes

Remove the 0 from the topic. We are doing multiple GPS's on the same topic now.

Demo

ros2 topic echo /ap/navsat --once
header:
  stamp:
    sec: 1729471218
    nanosec: 41276000
  frame_id: '0'
status:
  status: 2
  service: 1
latitude: -35.36326217651367
longitude: 149.1652374267578
altitude: 584.0899658203125
position_covariance:
- 0.09000000357627869
- 0.0
- 0.0
- 0.0
- 0.09000000357627869
- 0.0
- 0.0
- 0.0
- 0.09000000357627869
position_covariance_type: 2
---

Based on

https://github.com/ArduPilot/ardupilot/pull/28291/files#diff-21a2f7a8c86c0d8903e0c8c3e48a7a8ae29fe5afa11878a8cd4b58224f31d94bR307

^ This does the same thing but allows two digits of instance number. I assume we will have less than 10 GPS's.

FYI @tizianofiorenzani

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55 Ryanf55 force-pushed the dds-set-gps-instance-in-navsatfix branch from 7fd7608 to b727e94 Compare October 21, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant