Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RF25): Do not create task if validation fails #253

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

sgarnica1
Copy link
Contributor

@sgarnica1 sgarnica1 commented Jun 6, 2024

Fix(RF25): Do not create task if validation fails

[RF25]: Do not create task if validation fails

Descripción

Se redefinió el orden de los errores para que la tarea se cree hasta que todas las validaciones se cumplan

Cambios realizados

  • Se modificó el archivo src/core/app/services/task.service.ts

Story Points

1

Pruebas

image

@sgarnica1 sgarnica1 self-assigned this Jun 6, 2024
@dembA7 dembA7 self-requested a review June 6, 2024 16:51
@dembA7 dembA7 merged commit e4dd867 into develop Jun 6, 2024
2 checks passed
@dembA7 dembA7 changed the title fix(tasks): do not create task if error fix(RF25): Do not create task if validation fails Jun 8, 2024
Copy link
Contributor

@Ian326 Ian326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants