Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RF25): Do not create task if validation fails #253

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(RF25): Do not create task if validation fails #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/core/app/services/task.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,6 @@ async function createTask(newTask: BareboneTask): Promise<Task | null> {
throw new Error('Worked hours must be lower than or equal to 1000');
}

const createdTask = await TaskRepository.createTask(task);
if (!createdTask) {
throw new Error('Task already exists');
}

if (newTask.endDate && project.endDate && !dateSmallerOrEqualThanOther(newTask.endDate, project.endDate))
throw new Error("Task's end date cannot be after the project's end date");

Expand All @@ -135,6 +130,11 @@ async function createTask(newTask: BareboneTask): Promise<Task | null> {
if (newTask.startDate && project.endDate && !dateSmallerOrEqualThanOther(newTask.startDate, project.endDate))
throw new Error("Task's start date cannot be after the project's end date");

const createdTask = await TaskRepository.createTask(task);
if (!createdTask) {
throw new Error('Task already exists');
}

if (newTask.idEmployee) {
const employee = await EmployeeRepository.findById(newTask.idEmployee);
if (!employee) {
Expand Down
Loading