Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow in-systick logging over bluetooth with DMA #351

Merged
merged 18 commits into from
Jan 17, 2019

Conversation

Peque
Copy link
Member

@Peque Peque commented Nov 23, 2018

Review #350 first.

Closes #28, closes #165, closes #123.

@Peque Peque added the wip label Nov 23, 2018
@Peque Peque added this to the Portugal 2019 milestone Nov 23, 2018
@Peque Peque self-assigned this Nov 23, 2018
@Peque Peque force-pushed the rtlogging branch 2 times, most recently from 083eadb to cdefc49 Compare November 24, 2018 17:10
@Peque Peque force-pushed the rtlogging branch 2 times, most recently from 86d7e71 to 80ddc40 Compare December 1, 2018 17:17
@Peque Peque requested a review from cua-cua December 1, 2018 17:20
@Peque Peque force-pushed the rtlogging branch 2 times, most recently from be8b763 to 3830da4 Compare December 3, 2018 21:10
Copy link
Member

@cua-cua cua-cua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked request changes because I'm not sure, but most of them are about documentation so it is almost aproved :)

src/logging.c Show resolved Hide resolved
src/logging.c Show resolved Hide resolved
src/logging.c Show resolved Hide resolved
src/logging.c Show resolved Hide resolved
src/logging.h Outdated Show resolved Hide resolved
src/control.c Show resolved Hide resolved
src/logging.h Outdated Show resolved Hide resolved
src/serial.c Show resolved Hide resolved
src/serial.c Outdated Show resolved Hide resolved
src/logging.h Show resolved Hide resolved
@Peque
Copy link
Member Author

Peque commented Dec 10, 2018

@cua-cua 1d04acf

@cua-cua
Copy link
Member

cua-cua commented Dec 10, 2018

okey makey

@Peque Peque requested a review from cua-cua December 11, 2018 18:38
src/serial.c Outdated Show resolved Hide resolved
src/serial.c Show resolved Hide resolved
src/serial.c Show resolved Hide resolved
src/serial.c Show resolved Hide resolved
src/serial.c Show resolved Hide resolved
src/serial.c Outdated Show resolved Hide resolved
src/setup.c Show resolved Hide resolved
@Peque Peque merged commit 27d1194 into Bulebots:master Jan 17, 2019
@Peque Peque deleted the rtlogging branch January 17, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants