-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow in-systick logging over bluetooth with DMA #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peque
force-pushed
the
rtlogging
branch
2 times, most recently
from
November 24, 2018 17:10
083eadb
to
cdefc49
Compare
Peque
force-pushed
the
rtlogging
branch
2 times, most recently
from
December 1, 2018 17:17
86d7e71
to
80ddc40
Compare
Peque
force-pushed
the
rtlogging
branch
2 times, most recently
from
December 3, 2018 21:10
be8b763
to
3830da4
Compare
They should be re-implemented using the new real-time logging capabilitites, if needed.
cua-cua
requested changes
Dec 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked request changes because I'm not sure, but most of them are about documentation so it is almost aproved :)
okey makey |
cua-cua
requested changes
Jan 15, 2019
cua-cua
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #350 first.
Closes #28, closes #165, closes #123.