-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a getting started tutorial #109
Conversation
… then render into docs
Additions:
Not implementedThis PR only addresses a single notebook. We will add some method to automate adding all the examples to the linked pages in the docs in a future PR. |
This is all looking great to me. I guess we need the build uncomment and the toy model example in tests removed and this is good to go? |
Yep. Also, CI check. It builds the docs locally, but still waiting for CI. EDIT: ofc, I'd forgotten I'd left build commented... |
The docs are broken on main (so I'm not sure how they build for you locally) due to #108 |
Hmmmm.... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 6 6
Lines 133 133
=======================================
Hits 130 130
Misses 3 3 ☔ View full report in Codecov by Sentry. |
… then render into docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. Two minor points
Note I think that #115 should be addressed here as its linked to this PR and @SamuelBrand1 likely has all the context here from freshly porting over the example |
OK, and I hadn't updated the notebook to reflect the new |
I think the only dep we didn't want in Test env was This PR closes #115 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM
This is WIP aimed at addressing #100 (and contributing to #97) using a Pluto notebook approach to documentation examples.
The approach is to create the getting started tutorial as a notebook, which is easy to develop and also works as a
.jl
script. HTML render for documentation can be supplied by PlutoStaticHTML.