Docstrings for all latentmodel types and generate_latent plus named arguments for constructors #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
SamuelBrand1
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 26 25 -1
Lines 228 228
=======================================
Hits 224 224
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
This PR has some major conflicts. Happy to resolve and then review. |
…hat-dispatch-on-them-plus-adding-keyword-args-as-required
seabbs
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
This looks good to me. @SamuelBrand1 can you check you are also happy?
seabbs
deleted the
139-document-all-latent-models-and-methods-that-dispatch-on-them-plus-adding-keyword-args-as-required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for documenting
AbstractLatentModelsubtypes and methods that dispatch on them.Current focus and decisions:
Follows #138 in decisions.
This PR is aimed at addressing #139 which is part of #35 and #97 .
Extra activity
@kwdefI am doing it, because this also makes example usage easier. This moves towards addressing Make all constructors have named and not positional arguments. #133 , but won't close this issue.