Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards improvement of docstrings for EpiModels #141

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

Goal

Bring improvements in doc string clarity into AbstractEpiModel subtype documentation.

My view is that the doc string layout for AbstractLatentModel subtypes and method dispatching on them was improved compared to #138. This PR aims to include backwards improvement in style for the structs/methods documented in #138 .

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (c407721) to head (ba2a134).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          25       25           
  Lines         228      228           
=======================================
  Hits          224      224           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs March 15, 2024 11:22
@seabbs seabbs force-pushed the backwards-improvement-of-docstrings branch from 085c4b9 to 97d8224 Compare March 15, 2024 11:24
@seabbs
Copy link
Collaborator

seabbs commented Mar 15, 2024

Doc changes look reasonable but the outstanding is merge conflicts due to the change in submodules and git losing track of the folders on this PR.

Base automatically changed from 139-document-all-latent-models-and-methods-that-dispatch-on-them-plus-adding-keyword-args-as-required to main March 15, 2024 14:24
@seabbs seabbs force-pushed the backwards-improvement-of-docstrings branch from 97d8224 to ba2a134 Compare March 15, 2024 15:04
@seabbs seabbs enabled auto-merge (squash) March 15, 2024 15:04
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement. Good to go.

@seabbs seabbs merged commit 43c448a into main Mar 15, 2024
10 checks passed
@seabbs seabbs deleted the backwards-improvement-of-docstrings branch March 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants