-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EpiModel
inner constructor for ingesting distributions directly.
#28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of really nice stuff here Sam. I left some nitpicky comments inline, but nothing major.
My only high-level question is how do we pass the latent process through to the EpiModel
struct? Both pieces are in here, but I don't see where they'll end up fitting together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good.
Abstracting the sparse matrix constructor into a new function and if/how we check for GI normalization inline are still outstanding. I don't mind if that's addressed here or in a future issue though.
I'm happy to do another pass on this tomorrow but for now flagging that we should either make unresolved conversations into issues or address here and rerevie. |
@seabbs I'm treating the comment about a utility for the sparse delay kernel as an issue. |
Sounds good. Can you link the issue in the comment thread so that it's easy to track the thread back? |
and then resolve the conversation (as unresolveed conversations are PR blockers) |
…test and update the `./test` env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good but a few potential merge issues and one clarifying question
As mentioned here. A step in getting the toy model functional is to improve ability to ingest distributions and operate on their discretisations.