Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EpiModel inner constructor for ingesting distributions directly. #28

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

As mentioned here. A step in getting the toy model functional is to improve ability to ingest distributions and operate on their discretisations.

Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of really nice stuff here Sam. I left some nitpicky comments inline, but nothing major.

My only high-level question is how do we pass the latent process through to the EpiModel struct? Both pieces are in here, but I don't see where they'll end up fitting together.

EpiAware/src/epimodel.jl Outdated Show resolved Hide resolved
EpiAware/src/epimodel.jl Show resolved Hide resolved
EpiAware/src/epimodel.jl Outdated Show resolved Hide resolved
EpiAware/src/models.jl Show resolved Hide resolved
EpiAware/src/models.jl Show resolved Hide resolved
EpiAware/src/models.jl Show resolved Hide resolved
EpiAware/test/predictive_checking/toy_model.jl Outdated Show resolved Hide resolved
@seabbs seabbs requested a review from zsusswein February 12, 2024 16:32
@zsusswein zsusswein mentioned this pull request Feb 12, 2024
Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

Abstracting the sparse matrix constructor into a new function and if/how we check for GI normalization inline are still outstanding. I don't mind if that's addressed here or in a future issue though.

@seabbs
Copy link
Collaborator

seabbs commented Feb 12, 2024

I'm happy to do another pass on this tomorrow but for now flagging that we should either make unresolved conversations into issues or address here and rerevie.

@SamuelBrand1
Copy link
Collaborator Author

@seabbs I'm treating the comment about a utility for the sparse delay kernel as an issue.

@zsusswein
Copy link
Collaborator

@seabbs I'm treating the comment about a utility for the sparse delay kernel as an issue.

Sounds good. Can you link the issue in the comment thread so that it's easy to track the thread back?

@seabbs
Copy link
Collaborator

seabbs commented Feb 12, 2024

and then resolve the conversation (as unresolveed conversations are PR blockers)

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good but a few potential merge issues and one clarifying question

EpiAware/test/test_epimodel.jl Outdated Show resolved Hide resolved
EpiAware/src/models.jl Show resolved Hide resolved
EpiAware/test/test_epimodel.jl Outdated Show resolved Hide resolved
@SamuelBrand1 SamuelBrand1 merged commit 03fe870 into main Feb 12, 2024
2 checks passed
@SamuelBrand1 SamuelBrand1 deleted the 15-functional-full-model branch February 12, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants