Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 563: Change lookback to 90 time steps #564

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

This small PR closes #563 .

All this PR does is change the lookback to 90 time steps. This removes the windowing effect on the Rt-without project whilst leaving a more reasonable default for any extension to a longer time series.

@SamuelBrand1 SamuelBrand1 linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="563-remove-inference-windowing", subdir="EpiAware")
using EpiAware

@SamuelBrand1 SamuelBrand1 requested a review from seabbs December 19, 2024 14:13
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This brings the pipeline back into line with the original analysis plan as discussed f2f

@seabbs seabbs enabled auto-merge December 19, 2024 14:35
@seabbs seabbs added this pull request to the merge queue Dec 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (9b467f2) to head (2e3458a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          60       60           
  Lines         863      863           
=======================================
  Hits          785      785           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 0d4095e Dec 19, 2024
10 checks passed
@seabbs seabbs deleted the 563-remove-inference-windowing branch December 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inference windowing
3 participants