-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding container args as well as improving docs #9
base: main
Are you sure you want to change the base?
Conversation
Hey @damonbayer, this is ready for review. It took me longer than I wanted b/c of the way that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvegayon Thanks for this! I think I'm too much of a novice to provide a good review. The first time I ever edited a containerfile was last week. That said, the examples look good.
This pull request includes several updates to the
twostep-container-build
GitHub Action, focusing on enhancing its functionality and documentation. The changes include modifications to workflow files, updates to the README, and improvements to the action's configuration and examples.Workflow Updates:
test
job totest-no-args
and added a new jobtest-with-args
in.github/workflows/test-twostep-container-build.yml
to test the action with arguments. [1] [2]Documentation Updates:
README.md
to include new sections on inputs and outputs, and modified the example usage to reflect the latest changes. [1] [2] [3] [4] [5]Action Configuration Updates:
twostep-container-build/action.yml
with additional inputs for build arguments and defined outputs for the action. [1] [2] [3] [4]Example Updates:
examples/Containerfile
andexamples/Containerfile.dependencies
to reflect the new build process and added labels for better tracking. [1] [2]Makefile
in the examples directory to simplify the build process for users.