Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding container args as well as improving docs #9

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented Dec 16, 2024

This pull request includes several updates to the twostep-container-build GitHub Action, focusing on enhancing its functionality and documentation. The changes include modifications to workflow files, updates to the README, and improvements to the action's configuration and examples.

Workflow Updates:

  • Renamed the test job to test-no-args and added a new job test-with-args in .github/workflows/test-twostep-container-build.yml to test the action with arguments. [1] [2]

Documentation Updates:

  • Updated the README.md to include new sections on inputs and outputs, and modified the example usage to reflect the latest changes. [1] [2] [3] [4] [5]

Action Configuration Updates:

  • Enhanced the twostep-container-build/action.yml with additional inputs for build arguments and defined outputs for the action. [1] [2] [3] [4]

Example Updates:

  • Updated examples/Containerfile and examples/Containerfile.dependencies to reflect the new build process and added labels for better tracking. [1] [2]
  • Added a Makefile in the examples directory to simplify the build process for users.

@gvegayon gvegayon requested a review from damonbayer December 16, 2024 18:10
@gvegayon gvegayon marked this pull request as draft December 16, 2024 18:10
@gvegayon gvegayon marked this pull request as ready for review December 16, 2024 20:44
@gvegayon
Copy link
Member Author

Hey @damonbayer, this is ready for review. It took me longer than I wanted b/c of the way that ARG works... it is cleared after the FROM statement. I think you knew that, but I didn't! The way in which the action is now should do what you want.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gvegayon Thanks for this! I think I'm too much of a novice to provide a good review. The first time I ever edited a containerfile was last week. That said, the examples look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants