-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce config environment variable #3006
Open
BobanL
wants to merge
108
commits into
main
Choose a base branch
from
boban/2873-env-variables-next-runtime-env
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker compose --env-file .env.local --profile "*" up to test with different configs
…env-variables-next-runtime-env
…env-variables-next-runtime-env
BobanL
requested review from
akasper,
angelathe,
austin-hall-skylight,
gordonfarrell,
JNygaard-Skylight,
lina-roth,
mcmcgrath13 and
robertmitchellv
as code owners
December 19, 2024 15:15
BobanL
changed the title
collection env variables with next runtime env
feat: introduce config environment variable
Dec 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #3059 first
PULL REQUEST
Summary
CONFIG
variable that, if set will, replaceNEXT_PUBLIC_NON_INTEGRATED_VIEWER
,SOURCE
,METADATA_DATABASE_TYPE
,METADATA_DATBASE_SCHEMA
,NBS_AUTH
CONFIG
value is set then the values will have to be set manuallynext-runtime-env
to setNEXT_PUBLIC_NON_INTEGRATED_VIEWER
value from the register function.APP_ENV
withNBS_AUTH
to make it more clear what it doesCleanup 🧹
SQL_SERVER_USER
andSQL_SERVER_PASSWORD
since .env was deleted--abort-on-container-exit
will stop all containers if any container stops. Since Azure-storage depended on azure-init completing it would stop the entire convert-seed-data.Related Issue
Fixes #2873
Acceptance Criteria
Testing
CONFIG
variable to test different combinations