Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resolve reference from fhir-converter #3061

Closed
wants to merge 1 commit into from

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 13, 2024

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (5aed2ab) to head (941b8d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
- Coverage   86.00%   83.43%   -2.58%     
==========================================
  Files         162      132      -30     
  Lines       10855     8154    -2701     
==========================================
- Hits         9336     6803    -2533     
+ Misses       1519     1351     -168     
Flag Coverage Δ
fhir-converter 77.62% <100.00%> (-1.21%) ⬇️
ingestion 64.08% <ø> (ø)
message-parser 96.53% <ø> (ø)
message-refiner 92.85% <ø> (ø)
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
containers/fhir-converter/app/main.py 96.66% <100.00%> (-0.08%) ⬇️
containers/fhir-converter/app/service.py 96.73% <ø> (-0.41%) ⬇️
...ainers/fhir-converter/tests/test_FHIR-Converter.py 98.81% <ø> (-0.12%) ⬇️

... and 30 files with indirect coverage changes

@BobanL BobanL closed this Dec 13, 2024
@BobanL BobanL deleted the boban/remove-resolve-reference branch December 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant